swift: add NWConnection-inspired Swift 6 compatible TailscaleKit.framework #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! File an oss tracking bug for the effort overall? (which can explain the overall goal, links to docs, etc) There will probably be follow-up changes I'd guess. |
barnstar
force-pushed
the
barnstar/swift-bindings
branch
from
6d61c38 to
0b70b0b
Compare
agottardo
reviewed
Oct 28, 2024
| </BuildableProductRunnable> | ||
| <EnvironmentVariables> | ||
| <EnvironmentVariable | ||
| key = "TSNET_FORCE_LOGIN" |
There was a problem hiding this comment.
Maybe explain in the docs what this does?
agottardo
reviewed
Oct 28, 2024
|
Looks great! I would rename this to |
agottardo
approved these changes
Oct 28, 2024
barnstar
force-pushed
the
barnstar/swift-bindings
branch
2 times, most recently
from
d691004 to
a5c4c78
Compare
barnstar
force-pushed
the
barnstar/swift-bindings
branch
from
a5c4c78 to
8ee2eb0
Compare
barnstar
force-pushed
the
barnstar/swift-bindings
branch
from
8ee2eb0 to
271283d
Compare
barnstar
changed the title
barnstar
force-pushed
the
barnstar/swift-bindings
branch
from
271283d to
a28e351
Compare
updates tailscale/tailscale#13937 Builds a TailscaleKit.framework which wraps libtailscale.a in an actor, providing IncomingConnection, Listener, and OutgoingConnection types which are more usable in pure async Swift code. The method signatures are intended to be similar in form to NWConnection. We also provide an extension to URLSession so you can make URL requests via the user-space proxy. Adds a static library mirroring much of the test control utilities in go, minus the dependency on testing, so that we can export the signatures and link it to tests that cannot run in go. Added functionality to get both the local interface IPs as well as the remote IP of incoming connections accepted by a listener. Fixed a bug in the log writer so we append a newline. This also updates to the latest go toolchain and tailscale version. Signed-off-by: Jonathan Nobels <[email protected]>
barnstar
force-pushed
the
barnstar/swift-bindings
branch
from
a28e351 to
f0921b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tailscale/tailscale#13937
Builds a Tailscale.framework which wraps libtailscale.a in an actor, providing IncomingConnection, Listener, and OutgoingConnection types which are more usable in pure async Swift code. The method signatures are intended to be similar in form to NWConnection. An extension to NSURLSessionConfiguration is provided which will give you a config that lets you do URL requests via the loopback proxy to hosts on your tailnet.
Added functionality to get both the local interface IPs as well as the remote IP of incoming connections accepted by a listener.
Fixed a bug in the log writer so we append a newline.
This also updates to the latest go toolchain and tailscale version.