-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): add airdrop contracts (not final) #15122
Closed
Closed
Changes from 1 commit
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
74783f3
feat(protocol): Contestable zkRollup [DRAFT] (#14703)
dantaik 3e7e6c3
Merge branch 'main' into contestable-zkrollup
dantaik fb5ca45
Update LibProposing.sol
dong77 022745f
more
dong77 5fc177d
Update LibProposing.sol
dong77 42e57bb
Update TaikoData.sol
dong77 1f55b21
rename
dong77 c6ee6e3
Merge branch 'main' into contestable-zkrollup
davidtaikocha 8a64422
Merge branch 'main' into contestable-zkrollup
adaki2004 795d6f1
Merge branch 'main' into contestable-zkrollup
adaki2004 72b2de6
Fix tran.timestamp for first proveBlock() txn
adaki2004 3948721
Merge branch 'main' into contestable-zkrollup
dantaik 917d26d
refactor(protocol): further improve EIP1559 on L2 (#14724)
dantaik cfe5966
feat(protocol): Contestable zkRollup v2 (observations) [DRAFT] (#14721)
adaki2004 ea51ba3
Emit an event (#14731)
dantaik f3c6a36
Merge branch 'main' into contestable-zkrollup
dantaik 0e7258f
Update LibProving.sol
dong77 25043b6
fix(protocol): fixed a minor issue with getting EIP1559 base fee func…
dantaik 830334f
Merge branch 'main' into contestable-zkrollup
adaki2004 381abaa
fix(protocol): Hybrid rollup tests and small fixes (#14766)
adaki2004 0be3527
fix(protocol): allow prover assignment with different proving fees (#…
dantaik e86320f
feat(protocol): extract tier configs into a provider contract for dec…
dantaik edc9ccb
refactor(protocol): cleanup solidity imports (#14772)
dantaik a7edd7b
Update TaikoL2.sol
dong77 7f8a1bc
fix(protocol): Fix tests (#14783)
adaki2004 a7133cf
Merge branch 'main' into contestable-zkrollup
dantaik 6c17b0a
more
dong77 a58c2a0
Merge branch 'main' into contestable-zkrollup
davidtaikocha 248b5da
address build warning
adaki2004 a353265
remove debug prints
adaki2004 f47cc85
Optimize gas (#14803)
dantaik 1a6744f
Merge branch 'main' into contestable-zkrollup
dantaik 00f0be1
Merge branch 'main' into contestable-zkrollup
dantaik 4528e7b
fix test command
adaki2004 77d26e3
fix unit test command
adaki2004 6de9c60
Fuzz seed workaround
adaki2004 36b1ece
remove unused eip1559config
adaki2004 0e340a0
Merge branch 'main' into contestable-zkrollup
davidtaikocha d07eea1
update comment
adaki2004 0b4ba34
feat(protocol): emit events in LibTaikoToken (#14821)
dantaik 535ca31
refactor(protocol): rename variables (#14820)
dantaik 7274072
Update packages/protocol/contracts/L1/libs/LibProposing.sol
dantaik 90612d2
feat(protocol): rename config providers and add ZKRollupConfigProvide…
dantaik bf7262c
fix(protocol): fixes based on David's review (#14828)
dantaik 8770d6c
feat(protocol): Guardian can return unprovable bonds (#14830)
adaki2004 67f4edf
Update GuardianVerifier.sol
dong77 7f34319
Merge branch 'main' into contestable-zkrollup
dantaik 5a2aa13
feat(protocol): update `DeployOnL1` script based on Contestable zkRol…
davidtaikocha 29bfd96
feat(protocol): add extraData to proposed block (#14846)
dantaik be0fe1c
feat(protocol): add `minTier` to `BlockProposed` event (#14859)
davidtaikocha ea737d3
feat(protocol): add a missing slot value in pre-deployed `TaikoL2` ge…
davidtaikocha 61268f5
Merge branch 'main' into contestable-zkrollup
davidtaikocha 781464f
refactor(protocol): reimplement curve(amm)-based 1559 for L2a (#14885)
dantaik 6a6cc8b
chore(protocol): Contestable rollup additions (design docs, documenta…
adaki2004 d072fc5
feat(eventindexer): Contestable zkrollup eventindexer (#14892)
cyberhorsey 14d5ffd
fix genesis test
adaki2004 324be43
remove parentTimestamp from taikoL2.ts
adaki2004 a74f44f
Merge branch 'alpha-6' into contestable-zkrollup
dantaik 4c78ddb
feat(protocol): implemented partial and more fair block proposal rew…
adaki2004 49efd75
feat(protocol): lower top tier proof cost (#14922)
dantaik 2bcf2bf
feat(protocol): allow checking config after initialization (#14924)
dantaik b3a77cc
feat(protocol): reward proposer using gas used on L2 (#14929)
dantaik 6f88830
Update TaikoErrors.sol
dong77 3d3e1ab
Merge branch 'alpha-6' into contestable-zkrollup
dantaik cd76f60
refactor(protocol): update TaikoL2.sol (#14947)
mvidovic-tuple 2511b58
Update TaikoL2.sol
dong77 1f3fd0f
Update TaikoL2.sol
dong77 d9e3617
pnpm update --latest
dong77 7d947b2
pnpm update --latest
dong77 6772f94
refactor(protocol): address manager cannot be changed, only upgradabl…
dantaik 22c4a5a
fix(protocol): Revert long imports (hardhat seems issues parsing rema…
adaki2004 6945598
feat(protocol): support multi-hop bridging & add SGX prover (#14954)
dantaik 56efc69
merge
dong77 7a58e95
Add refund in onMessageRecalled
adaki2004 b8e699c
fix typo
adaki2004 372b8e5
Added sgxAndZk verifier to deployment
adaki2004 ee4f93e
Test for proof and hop proof
adaki2004 362ee57
getInstance -> calcInstance
dong77 ee6f34d
remove errors
dong77 cb21e4e
Update SgxVerifier.sol
dong77 00e20be
fix(protocol): Fix LibAddress (#14989)
adaki2004 4d740b5
add warning acc. to Brecht
adaki2004 74d2649
function order change
adaki2004 d63982e
function order change2
adaki2004 56c0198
chore(protocol): deploy `ProxiedGuardianProver` in `DeployOnL1` scrip…
davidtaikocha 409f368
feat(protocol): remove block reward (#14992)
dantaik 5b7fc25
feat(protocol): Simulate and plot l2 basefee (#14997)
adaki2004 394ff17
refactor(protocol): improve TaikoToken and allow pausing Bridge/Vault…
dantaik 2cc9863
Merge branch 'contestable-zkrollup-consolidated' into contestable-zkr…
dantaik 8ba512b
feat(protocol): set taiko token supply to 1 billion (#15007)
dantaik 8e6c047
feat(relayer): Relayer multihop (#15000)
cyberhorsey 9ca78ae
Add description
adaki2004 136ee0e
feat(protocol): Enable designated address to propose 1st block post-g…
dantaik edf9452
feat(repo): add a contract to handle token granting and unlocking (#1…
dantaik cb43010
fix(protocol): check l1BlockHash & l1SignalRoot in anchortx (#15035)
dantaik c334af7
merge
dong77 2a908be
merge
dong77 004e02a
test(protocol): fix workflow errors (#15043)
davidtaikocha 7363b64
feat(protocol): update A6 configurations (#15025)
davidtaikocha ff5d3da
bindings
cyberhorsey ac3856a
not every block is synced
cyberhorsey ca29a72
test
cyberhorsey c704bae
fix(protocol): Change sgx instanceId to 4bytes (#15092)
adaki2004 a31854d
feat(protocol): allow using both blob & calldata for DA (#15011)
dantaik 077b343
merge with main
dong77 0a2ab0c
Merge branch 'contestable-zkrollup' of https://github.com/taikoxyz/ta…
dong77 19e7ec1
feat(protocol): Return value to sgx addition (#15111)
adaki2004 99e3add
dont use process exit
adaki2004 2fc656f
move files
adaki2004 6bcb4d3
create a base airdrop contract
adaki2004 f2bdbf2
remove console log
adaki2004 ee9d8f1
improve the airdrop contract design (#15128)
dantaik f6e0637
mv
dong77 e6d6574
Update TimeLockTokenPool.sol
dong77 8a2d639
improve
dong77 ceec7b2
fix tests
dong77 c73a1ad
add input json file input param for claimlist
adaki2004 7777b48
Add another ERC20 token airdrop contracts
dong77 a62717d
Update ERC20Airdrop2.sol
dong77 deb3d0d
Finish time-lock airdrop code and test
adaki2004 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this (reentrancy check) is not necessary, we solved it 'in-house' already.
A contract is vulnerable if it
calls
,sends
ortransfers
to an untrusted address (e.g.: contract with malicious fallback function).A design to prevent that is check-effects interaction. (https://fravoll.github.io/solidity-patterns/checks_effects_interactions.html)
We already have that given (by line 52 + line 58), because the only place an untrusted address can be invoked, is within
_claimWIthData()
but we already marked the hash asused
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are sending an ERC1155 token to an target address and the target address is a contract and implement a ERC1155 callback, then the callback can call this contract to re-enter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But it would revert because the hash is already “used”. (Line 60)