Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmod: resolve symbolic link in firmware path #3327

Closed
wants to merge 1 commit into from

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Jan 5, 2025

Otherwise, if a symbolic link firmware path is specified by a module, only the symbolic link is kept but the symbolic link target will be removed.

  • Before:
usr/lib/firmware
├── cavium
│   └── cnn55xx_se.fw.xz
├── cxgb4
│   ├── t4fw.bin.xz -> t4fw-1.27.5.0.bin.xz    <- broken
│   ├── t5fw.bin.xz -> t5fw-1.27.5.0.bin.xz    <- broken
│   └── t6fw.bin.xz -> t6fw-1.27.5.0.bin.xz    <- broken
  • After:
usr/lib/firmware
├── cavium
│   └── cnn55xx_se.fw.xz
├── cxgb4
│   ├── t4fw-1.27.5.0.bin.xz
│   ├── t4fw.bin.xz -> t4fw-1.27.5.0.bin.xz
│   ├── t5fw-1.27.5.0.bin.xz
│   ├── t5fw.bin.xz -> t5fw-1.27.5.0.bin.xz
│   ├── t6fw-1.27.5.0.bin.xz
│   └── t6fw.bin.xz -> t6fw-1.27.5.0.bin.xz

Otherwise, if a symbolic link firmware path is specified by a module,
only the symbolic link is kept but the symbolic link target will be
removed.

- Before:
usr/lib/firmware
├── cavium
│   └── cnn55xx_se.fw.xz
├── cxgb4
│   ├── t4fw.bin.xz -> t4fw-1.27.5.0.bin.xz    <- broken
│   ├── t5fw.bin.xz -> t5fw-1.27.5.0.bin.xz    <- broken
│   └── t6fw.bin.xz -> t6fw-1.27.5.0.bin.xz    <- broken

- After:
usr/lib/firmware
├── cavium
│   └── cnn55xx_se.fw.xz
├── cxgb4
│   ├── t4fw-1.27.5.0.bin.xz
│   ├── t4fw.bin.xz -> t4fw-1.27.5.0.bin.xz
│   ├── t5fw-1.27.5.0.bin.xz
│   ├── t5fw.bin.xz -> t5fw-1.27.5.0.bin.xz
│   ├── t6fw-1.27.5.0.bin.xz
│   └── t6fw.bin.xz -> t6fw-1.27.5.0.bin.xz
@DaanDeMeyer
Copy link
Contributor

@yuwata Is this not similar or the same as #3312?

@yuwata
Copy link
Member Author

yuwata commented Jan 5, 2025

@yuwata Is this not similar or the same as #3312?

Oh, yes. And #3312 looks better to me. Closing.

@yuwata yuwata closed this Jan 5, 2025
@yuwata yuwata deleted the kmod-symlink branch January 5, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants