Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burn: Fail if no arguments are provided #3293

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

DaanDeMeyer
Copy link
Contributor

If no arguments are provided systemd-repart will operate on the device backing the rootfs which in the case of burn we definitely don't want to do most of the time so let's fail unless a device is explicitly provided.

Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, one comment.

mkosi/burn.py Outdated Show resolved Hide resolved
If no arguments are provided systemd-repart will operate on the
device backing the rootfs which in the case of burn we definitely
don't want to do most of the time so let's fail unless a device is
explicitly provided.
@DaanDeMeyer DaanDeMeyer merged commit 404760a into systemd:main Dec 22, 2024
28 of 36 checks passed
@DaanDeMeyer DaanDeMeyer deleted the burn branch December 22, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants