Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve "KernelModulesInitrd" description #3273

Closed
wants to merge 3 commits into from
Closed

Conversation

matmaer
Copy link

@matmaer matmaer commented Dec 13, 2024

  • added missing apostrophe to "modules" on the first line of the option's description
  • removed consecutive usage of "for each kernel that mkosi assembles a unified kernel image for"
  • replace "we" with "mkosi"
  • improved readability if you agree
  • shortened the option description by 10%, without leaving out facts if you agree

modified: mkosi/resources/man/mkosi.1.md

mm added 2 commits December 13, 2024 08:01
…on's description

- removed consecutive usage of "for each kernel that mkosi assembles a unified kernel image for"
- replace "we" with "mkosi"
- improved readability if you agree
- shortened the option description by 10%, without leaving out facts if you agree

modified:   mkosi/resources/man/mkosi.1.md
@DaanDeMeyer DaanDeMeyer requested a review from behrmann December 13, 2024 09:01
Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please squash both commits into one, since the second one removes a new line the first one introduces.

Also, please don't start the commit message with a dash. For the commit a simple message like "man: Improve style of KernelModulesInitrd" is fine, since the actual changes are readily available from the diff.

mkosi/resources/man/mkosi.1.md Outdated Show resolved Hide resolved
improve accuracy suggested by behrmann

Co-authored-by: Jörg Behrmann <[email protected]>
@matmaer
Copy link
Author

matmaer commented Dec 13, 2024

Thanks for the PR!

Please squash both commits into one, since the second one removes a new line the first one introduces.

Also, please don't start the commit message with a dash. For the commit a simple message like "man: Improve style of KernelModulesInitrd" is fine, since the actual changes are readily available from the diff.

Thanks for the PR!

Please squash both commits into one, since the second one removes a new line the first one introduces.

Also, please don't start the commit message with a dash. For the commit a simple message like "man: Improve style of KernelModulesInitrd" is fine, since the actual changes are readily available from the diff.

checking how to squash and re-push

@matmaer matmaer closed this Dec 13, 2024
@matmaer
Copy link
Author

matmaer commented Dec 14, 2024

I am sorry but can you re-open the PR?
Otherwise we lose your feedback and corrections.
Lesson learned, I want to correct the PR itself instead of making a new one.

@behrmann
Copy link
Contributor

Sorry, I can't either. Closing PRs is unfortunately a pretty final thing most of the time. Just open a new PR, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants