Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in detect shell template #18

Closed
wants to merge 3 commits into from
Closed

Fix bugs in detect shell template #18

wants to merge 3 commits into from

Conversation

ChaosCypher
Copy link

@ChaosCypher ChaosCypher commented Dec 19, 2022

  • fixes array bug when passing options to command-line script (Noted in a currently open PR)
  • remove using backticks as this was deprecated
  • add double quoting around variables that could have accidental/unintended splitting when invoked
  • add proper exit code for failures (negative numbers are not interpreted by SIGNALS)
  • update detect7.sh in earlier versions

@ChaosCypher ChaosCypher closed this by deleting the head repository Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant