Bug-fix: attempting to update review comment from issue branch, path mismatch #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the changes in |
bug-fix: comment link and path mismatch
adrian-kong
changed the title
adrian-kong
commented
Sep 28, 2023
| @@ -105,7 +105,7 @@ async function run(): Promise<void> { | |||
| for (const comment of actionIssueComments) { | |||
| if (comment.body !== undefined && isPresent(comment.body)) { | |||
| info(`Comment ${comment.id} represents a Coverity issue which is no longer present, updating comment to reflect resolution.`) | |||
| updateExistingReviewComment(comment.id, createNoLongerPresentMessage(comment.body)) | |||
| updateExistingIssueComment(comment.id, createNoLongerPresentMessage(comment.body)) | |||
There was a problem hiding this comment.
main bug causing http error, attempting to call update review under issue branch
adrian-kong
commented
Sep 28, 2023
| @@ -128,7 +128,7 @@ async function run(): Promise<void> { | |||
| } | |||
|
|
|||
| function isInDiff(issue: IssueOccurrence, diffMap: DiffMap): boolean { | |||
| const diffHunks = diffMap.get(issue.mainEventFilePathname) | |||
| const diffHunks = diffMap.get(relativizePath(issue.mainEventFilePathname)) | |||
There was a problem hiding this comment.
this also needs to be normalized otherwise they won't match
adrian-kong
commented
Sep 28, 2023
Comment on lines
+67
to
+76
| function zTable(input: string) { | ||
| let table = new Array<number>(input.length).fill(0) | ||
| for (let i = 1; i < input.length; i++) { | ||
| for (let j = 0; j < input.length - i; j ++) { | ||
| if (input.charAt(j) != input.charAt(i + j)) continue | ||
| table[i]++ | ||
| } | ||
| } | ||
| return table | ||
| } |
There was a problem hiding this comment.
this can be optimized by terminating early but not really necessary since path are tiny
adrian-kong
commented
Sep 28, 2023
Comment on lines
+85
to
+89
| // this should give `diff --git a/path b/path` | ||
| // to get the file itself, we can use longest string match on `path b/path` | ||
| // since we definitely know paths are equal, path must be the longest string | ||
| path = line.substring("diff --git a/".length) | ||
| path = path.substring(0, Math.max(...zTable(path))) |
There was a problem hiding this comment.
basically doing a naive longest string match with prefix here to find the path without splitting
adrian-kong
commented
Sep 28, 2023
Comment on lines
+36
to
+39
| let length = (process.env.GITHUB_WORKSPACE ?? "undefined").length | ||
| // if workspace is /__w, replace as /home/runner/work | ||
| if (path.startsWith("/__w")) { | ||
| path = "/home/runner/work" + path.substring("/__w".length) |
There was a problem hiding this comment.
json outputs
"mainEventFilePathname" : "/__w/starling-core/starling-core/public_types/src/external_functions.cc",
with /__w prefix, due to running in docker.
this doesn't fix general case but patches at the moment.
this needs to be raised as issue #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a call to update a review comment under the issue comment branch which leads to issue #47
This also patches path mismatches where coverity results json outputs
This PR has been packaged and tested.