Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] feat(upgrade): bump codebase to latest sylius version #42

Merged
merged 3 commits into from
Jan 29, 2025
Merged

[1.x] feat(upgrade): bump codebase to latest sylius version #42

merged 3 commits into from
Jan 29, 2025

Conversation

maxperei
Copy link
Member

@maxperei maxperei commented Dec 24, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Fixed issue n/a

@maxperei maxperei force-pushed the feat/migration-sylius-latest-v1 branch 7 times, most recently from ae79f94 to fc9e7ef Compare December 27, 2024 11:57
@maxperei maxperei requested a review from Jibbarth December 30, 2024 13:35
Jibbarth
Jibbarth reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but great job done here 👍

README.md Outdated Show resolved Hide resolved
src/Controller/MaintenanceConfigurationController.php Outdated Show resolved Hide resolved
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
src/Voter/IsMaintenanceVoter.php Outdated Show resolved Hide resolved
@maxperei maxperei force-pushed the feat/migration-sylius-latest-v1 branch from fc9e7ef to c228520 Compare December 31, 2024 09:25
@maxperei maxperei force-pushed the feat/migration-sylius-latest-v1 branch from c228520 to 3fde601 Compare December 31, 2024 09:27
@maxperei maxperei requested a review from oallain January 14, 2025 13:22
@maxperei maxperei requested a review from Jibbarth January 23, 2025 09:31
@maxperei maxperei force-pushed the feat/migration-sylius-latest-v1 branch from 61ae7e8 to 5b8c34e Compare January 23, 2025 09:45
Jibbarth
Jibbarth approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Jibbarth Jibbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work, and well done 😎

Thanks @maxperei

@oallain oallain deleted the branch main January 29, 2025 09:09
@oallain oallain closed this Jan 29, 2025
@oallain oallain reopened this Jan 29, 2025
oallain
oallain approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 💪🏼

@oallain oallain merged commit a62126f into main Jan 29, 2025
17 checks passed
@oallain oallain deleted the feat/migration-sylius-latest-v1 branch January 29, 2025 09:52
@oallain oallain mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oallain oallain oallain approved these changes

@Jibbarth Jibbarth Jibbarth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxperei @Jibbarth @oallain