-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions workflow to run PR benchmark changes in CI #92
Conversation
I'm clearly doing something stupid with Git here but can't work out what. I'm doing |
The strange thing is that the current workflow uses the checkout action to checkout a different repo: sympy_benchmarks/.github/workflows/run-benchmarks.yml Lines 13 to 17 in 5563b6d
That effectively does git clone sympy && cd sympy . The change in this PR is to then use the checkout action again with
I'm not really sure what the effect of this is but it seems like it is trying to checkout one repo while already inside another. I think that the problem here is using the checkout action to checkout the sympy repo in the first place. That should just checkout the PR branch of the sympy_benchmarks repo as is standard for CI that runs on a PR. Then there can be a separate step to checkout sympy which can just use |
Thanks for the insight, @oscarbenjamin. These changes have certainly cleaned up what's going on and make a lot more sense. asv is actually being used in its intended way. |
Thanks for the fix @brocksam ! I guess the only way to know it has worked is to merge it. |
We can check gh-89 to see if it is fixed... |
This PR addresses the issue identified in PR #91 whereby benchmarks changed in a PR are not run in CI for that PR.