Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:twig-component] do not throw an error if config file does not exist #1640

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[make:twig-component] do not throw an error if config file does not exist #1640

merged 1 commit into from
Feb 6, 2025
+1 −1

Conversation

IndraGunawan
Copy link
Contributor

@IndraGunawan IndraGunawan commented Jan 2, 2025 •
edited
Loading

alternative of #1618

changes from #1571 break if config is in php files even $namespace has a default value

@IndraGunawan
Copy link
Contributor Author

@kbond any chance to review this?

kbond
kbond approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good call. But yeah, there definitely should be a more robust solution in the future.

@kbond kbond merged commit dcd2260 into symfony:main Feb 6, 2025
9 checks passed
@IndraGunawan IndraGunawan deleted the fix-error-on-php-config branch February 6, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IndraGunawan @kbond