This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
bug: bad verification guardAccess #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgdevweb
commented
May 17, 2019
jgdevweb
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #68 |
| License | MIT |
| Doc PR | reference to the documentation PR, if any |
dbu
suggested changes
May 20, 2019
There was a problem hiding this comment.
can you please explain what you are trying to fix?
the change as is makes it so that
- when the authorization checker is configured, we do not check authorization
- when the authorization checker is not configured, we fatal error on the next line as we try to call a method on null
could it be that your configuration makes the access checker say the request is not granted access to that resource?
|
Same, don't understand this change. All tests are passed correctly. |
|
please reopen or send a new pull request if there is something to be done about this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.