Add StressEnergyTensor free function #6457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please put in a comment about the purpose of this PR? What's new? Thanks. |
nilsdeppe
requested changes
Jan 29, 2025
Comment on lines
128
to
134
| const auto rho_h_star = | ||
| (get(rest_mass_density) + | ||
| get(rest_mass_density) * get(specific_internal_energy)) + | ||
| get(pressure) + square(get(comoving_magnetic_field_magnitude)); | ||
|
|
||
| const auto p_star = | ||
| get(pressure) + square(get(comoving_magnetic_field_magnitude)) / 2.; |
There was a problem hiding this comment.
You don't want auto here because this creates an expression tree that gets evaluated many times in the loop below. Specify the type
Comment on lines
+40
to
+57
| void comoving_magnetic_field( | ||
| gsl::not_null<tnsr::A<DataType, 3>*> result, | ||
| const tnsr::I<DataType, 3>& spatial_velocity, | ||
| const tnsr::I<DataType, 3>& magnetic_field, | ||
| const Scalar<DataType>& magnetic_field_dot_spatial_velocity, | ||
| const Scalar<DataType>& lorentz_factor, const tnsr::I<DataType, 3>& shift, | ||
| const Scalar<DataType>& lapse); | ||
|
|
||
| template <typename DataType> | ||
| tnsr::A<DataType, 3> comoving_magnetic_field( | ||
| const tnsr::I<DataType, 3>& spatial_velocity, | ||
| const tnsr::I<DataType, 3>& magnetic_field, | ||
| const Scalar<DataType>& magnetic_field_dot_spatial_velocity, | ||
| const Scalar<DataType>& lorentz_factor, const tnsr::I<DataType, 3>& shift, | ||
| const Scalar<DataType>& lapse); | ||
|
|
There was a problem hiding this comment.
Factor this function into its own commit and add a test
| @@ -70,23 +99,78 @@ void stress_trace(gsl::not_null<Scalar<DataType>*> result, | |||
| (square(get(lorentz_factor)) * get(spatial_velocity_squared) + 1.); | |||
| } | |||
|
|
|||
| template <typename DataType> | |||
| void stress_energy_tensor( | |||
| gsl::not_null<tnsr::AA<DataType, 3>*> result, | |||
| get(pressure) + square(get(comoving_magnetic_field_magnitude)); | ||
|
|
||
| const auto p_star = | ||
| get(pressure) + square(get(comoving_magnetic_field_magnitude)) / 2.; |
There was a problem hiding this comment.
don't divide by two, multiply by 0.5 on the left
| const tnsr::I<DataType, 3>& magnetic_field, | ||
| const tnsr::ii<DataType, 3>& spatial_metric, | ||
| const tnsr::II<DataType, 3>& inverse_spatial_metric) { | ||
| const auto inverse_spacetime_metric = |
There was a problem hiding this comment.
I'm generally unhappy about the large number of allocations in this function. It would be good to switch to the not_null versions and preallocate in a Variables
jyoo1042
force-pushed
the
Stress
branch
2 times, most recently
from
4046b96 to
175779d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding a function to evaluate the stress-energy tensor, which currently does not exist in StressEnergy.cpp
This will be mainly used for evaluating diagnostics for accretion disk simulations.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments