Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizational changes to shared CCE code #6354

Merged
merged 8 commits into from
Nov 11, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Oct 29, 2024

Proposed changes

This is sort of just a mish-mash of various changes I've made while updating the ReduceCceWorldtube executable. Most of it is just clarifying/organizing code that's shared. Future PRs will make more substantial changes to ReduceCceWorldtube.

Towards #6246

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsdeppe October 29, 2024 18:01
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few small suggestions you can squash immediately

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash immediately.

#include <string>
#include <vector>

#include "Evolution/Systems/Cce/Tags.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI clang-tidy is related to this include. I believe you don't actually need this in the hpp and can move it to the cpp, which should fix the issue.

@nilsdeppe nilsdeppe merged commit e7fa9dd into sxs-collaboration:develop Nov 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants