Use PostNewtonian.jl for initial orbital parameters #6224
+122
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
pn_initial_orbital_params
branch
6 times, most recently
from
2f85cfc to
6cafeef
Compare
nilsvu
force-pushed
the
pn_initial_orbital_params
branch
3 times, most recently
from
a0ab56f to
14a0626
Compare
Replaces the dependence on SpEC to compute low-eccentricity initial orbital parameters with the `sxs` package. It provides the PN approximations at higher PN order than SpEC, is much faster, and avoids spurious output from old Fortran code (LSODA) that was used in SpEC. The PN approximations are provided through the `PostNewtonian.jl` Julia package, so Julia will be downloaded on first use, which may take a few minutes.
nilsvu
force-pushed
the
pn_initial_orbital_params
branch
from
f6bb368 to
55e160d
Compare
knelli2
added
ci/cd
knelli2
requested changes
Nov 1, 2024
Comment on lines
+28
to
+30
| pn = PostNewtonian.BBH( | ||
| np.array( | ||
| [1.0 / (1.0 + q), q / (1.0 + q), *chiA, *chiB, 1, 0, 0, 0, 1, 0] |
There was a problem hiding this comment.
Please add a note what these magic 1s and 0s are. I believe they are the following, but the docs/code of the julia implementation don't match so I'm unsure...
1 = v (velocity???)
0, 0, 0, 1 = rotor (quaternion??)
0 = phi
Comment on lines
+32
to
+33
| ) | ||
| pn.state[12] = PostNewtonian.separation_inverse(r, pn) |
There was a problem hiding this comment.
Why replace? Please add some docs
Comment on lines
+12
to
+14
| # Disable this test if using jemalloc as a shared library, because Julia | ||
| # doesn't like the 'LD_PRELOAD' trick to load jemalloc for Pybindings. | ||
| if (NOT "${JEMALLOC_LIB_TYPE}" STREQUAL SHARED) |
There was a problem hiding this comment.
Will the source code work in the CLI if we are using JEMALLOC?
|
Also needs a rebase to fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaces the dependence on SpEC to compute low-eccentricity initial orbital parameters with the
sxspackage. It provides the PN approximations at higher PN order than SpEC, is much faster, and avoids spurious output from old Fortran code (LSODA) that was used in SpEC.The PN approximations are provided through the
PostNewtonian.jlJulia package, so Julia will be downloaded on first use, which may take a few minutes.See also moble/PostNewtonian.jl#41, which made this possible.
Upgrade instructions
To use low-eccentricity initial orbital parameters for BBH initial data, install the
sxspackage in your Python environment:# In the build directory: ./bin/python-spectre -m pip install sxsNow you can use
./bin/spectre bbh generate-idwith the--eccentricity=0option.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments