-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add section about issues with navigation to known issues #198
Conversation
✅ Deploy Preview for splendorous-kataifi-9ae281 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Great idea. I would slightly rephrase the first bullet point — maybe "One of the containers is missing in the old or new page" is a bit more to the point than "mismatch" in my opinion. And should we add a note about installing the debug plugin to this bullet point as well? We could add a check there that warns about missing containers directly on load to prevent the error being swallowed by the hard page load. Happy to do that :) |
I never found the debug plugin to be the most useful TBH... but it wouldn't hurt to add a reference to it somewhere along the lines here I guess. Would you like to push directly to this PR? :) |
Alright, added a note about debug plugin, and a link to the devtools manual on the preserve-log option. Couldn't help it and simplified the wording here and there, feel free to revert if it distorts what you were trying to say. Ready to go from my end :) |
🤝 |
@hirasso I've added some more checks to the debug plugin to make it actually useful for newcomers. |
Description
Direct link to preview deploy: https://deploy-preview-198--splendorous-kataifi-9ae281.netlify.app/getting-started/common-issues/#the-browser-performs-a-hard-visit-instead-of-a-swup-transition
Checks
master
branchnpm run lint
)