feat(cli): keep temp files in verbose mode

swordev · Oct 4, 2024 · c534a37 · c534a37
1 parent ed78354
commit c534a37
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/packages/cli/src/actions/BackupAction.ts b/packages/cli/src/actions/BackupAction.ts
@@ -272,7 +272,7 @@ export class BackupAction {
   }
   async exec() {
     const { options, settings } = this;
-    const gc = new GargabeCollector();
+    const gc = new GargabeCollector(this.options.verbose);
     const pm = new ProgressManager({
       verbose: options.verbose,
       tty: settings.tty,

diff --git a/packages/cli/src/actions/ExportAction.ts b/packages/cli/src/actions/ExportAction.ts
@@ -147,7 +147,7 @@ export class ExportAction {
   }
   async exec() {
     const { options, settings } = this;
-    const gc = new GargabeCollector();
+    const gc = new GargabeCollector(this.options.verbose);
     const pm = new ProgressManager({
       verbose: options.verbose,
       tty: settings.tty,

diff --git a/packages/cli/src/actions/RestoreAction.ts b/packages/cli/src/actions/RestoreAction.ts
@@ -168,7 +168,7 @@ export class RestoreAction {
   }
   async exec() {
     const { options, settings } = this;
-    const gc = new GargabeCollector();
+    const gc = new GargabeCollector(this.options.verbose);
     const pm = new ProgressManager({
       verbose: options.verbose,
       tty: settings.tty,

diff --git a/packages/cli/src/utils/temp.ts b/packages/cli/src/utils/temp.ts
@@ -82,7 +82,7 @@ export function useTempFile(path: string): AsyncDisposable & { path: string } {
 export class GargabeCollector {
   readonly paths: Set<string> = new Set();
   readonly children: Set<GargabeCollector> = new Set();
-  constructor(protected parent?: GargabeCollector) {
+  constructor(protected verbose?: boolean) {
     collectors.add(this);
   }
   pending() {
@@ -93,7 +93,7 @@ export class GargabeCollector {
   async cleanup() {
     for (const path of this.paths) {
       try {
-        await rmTmpDir(path);
+        if (!this.verbose) await rmTmpDir(path);
         this.paths.delete(path);
       } catch (_) {}
     }
@@ -119,7 +119,7 @@ export class GargabeCollector {
     };
   }
   create() {
-    const gc = new GargabeCollector();
+    const gc = new GargabeCollector(this.verbose);
     this.children.add(gc);
     return gc;
   }

diff --git a/packages/cli/test/utils/temp.test.ts b/packages/cli/test/utils/temp.test.ts
@@ -22,6 +22,16 @@ describe("GargabeCollector", () => {
     expect(gc.paths.size).toBe(0);
     await expectDir(path2, false);
   });
+
+  it("cleanup is disabled", async () => {
+    const gc = new GargabeCollector(true);
+    const path1 = await mkTmpDir("1");
+    await expectDir(path1);
+    expect(gc.paths.size).toBe(1);
+    await gc.cleanup();
+    await expectDir(path1, true);
+    expect(gc.paths.size).toBe(0);
+  });
   it("dispose", async () => {
     const gc = new GargabeCollector();
     const path1 = await mkTmpDir("1");