[APValue][BoundsSafety] Migrate away from PointerUnion::{is,get} (NFC) #9834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointerUnion::{is,get} are deprecated in PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
In this patch, I separated definitions of template functions from
the header, in order to avoid nasty instantiation issues seemingly
related to header dependency.
rdar://142909627
rapidsna
requested review from
cachemeifyoucan,
vsapsai,
delcypher,
hnrklssn and
patrykstefanski
|
@swift-ci test |
|
@swift-ci test llvm |
|
Confirm that can reproduce the linker errors locally. There are other warnings about PointerUnion deprecation but they aren't in APValue so they are out of scope for this change. |
cachemeifyoucan
requested changes
Jan 15, 2025
|
I can fix the link error. Adding explicit instantiation for |
|
@swift-ci test |
|
@swift-ci test llvm |
|
Looks like there are a bunch of unrelated build failures coming from other changes. |
cachemeifyoucan
approved these changes
Jan 15, 2025
| @@ -44,6 +44,38 @@ APValue::LValueBase::LValueBase(const ValueDecl *P, unsigned I, unsigned V) | |||
| APValue::LValueBase::LValueBase(const Expr *P, unsigned I, unsigned V) | |||
| : Ptr(P), Local{I, V} {} | |||
|
|
|||
| // Separated definitions of these template functions to avoid nasty build issues | |||
There was a problem hiding this comment.
Nit: guard this by // TO_UPSTREAM(BoundsSafety)?
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointerUnion::{is,get} are deprecated in PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa, cast and the llvm::dyn_cast
In this patch, I separated definitions of template functions from the header, in order to avoid nasty instantiation issues seemingly related to header dependency.
rdar://142909627