Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer-shell: chase wlr layer surface refactor #6528

Merged
merged 1 commit into from
Sep 23, 2021
Merged

layer-shell: chase wlr layer surface refactor #6528

merged 1 commit into from
Sep 23, 2021

Conversation

vyivel
Copy link
Member

@vyivel vyivel commented Sep 18, 2021

@vyivel vyivel force-pushed the layer-surface-refactor-chase branch 3 times, most recently from d999439 to 18076b1 Compare September 23, 2021 19:24
vyivel
vyivel commented Sep 23, 2021
View reviewed changes
sway/desktop/layer_shell.c
// So that we can easily arrange it
struct wlr_layer_surface_v1_state old_state = layer_surface->current;
layer_surface->current = layer_surface->client_pending;
layer_surface->current = layer_surface->pending;
Copy link
Member Author

@vyivel vyivel Sep 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but that's a hack and which might stop working once swaywm/wlroots#3151 is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, yeah, that isn't great. We should definitely fix it, maybe by passing a "configuring" layer surface to arrange_layers. Also arrange_layers shouldn't actually update the positions of the other layers just yet… We should wait for ack_configure.

Oh well.

emersion
emersion approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion merged commit b7b3ef6 into swaywm:master Sep 23, 2021
@vyivel vyivel deleted the layer-surface-refactor-chase branch September 23, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyivel @emersion