Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails' update script branch #1091

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

jlduran
Copy link
Contributor

@jlduran jlduran commented Jun 14, 2023

We should track the latest Rails release, not the main branch.

Fix 30a8745 by pointing the update script to the proper Rails branch.

Perhaps changing to a git model that more closely mimics Rails' is a better approach long-term. In the meantime, keep bumping the branch in the update script as Rails releases are published.

Fix #1086.

We should track the latest Rails release, not the main branch.

Fix 30a8745 by pointing the update script to the proper Rails branch.

Perhaps changing to a git model that more closely mimics Rails' is a
better approach long-term.  In the meantime, keep bumping the branch in
the update script as Rails releases are published.
@jlduran
Copy link
Contributor Author

jlduran commented Jun 14, 2023

@pama: This is an alternative approach: We should align to the latest production Rails release.

Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pama pama merged commit b3fad86 into svenfuchs:master Jun 23, 2023
@jlduran jlduran deleted the fix-rails-script-update-branch branch August 4, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants