Fix error seen when this gem installed but not specified as dependency in project #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboling
suggested changes
Dec 18, 2024
lib/rubygems_plugin.rb
Outdated
| require 'gem/release' | ||
| require 'rubygems/command_manager' | ||
| begin | ||
| require 'gem/release' |
There was a problem hiding this comment.
A better solution would be to use require_relative here. This is the answer for ensuring that libraries always load their internal files, rather than risking loading the wrong file via a load path search.
|
Took me a while to get it right |
|
Woohoo!! Thanks to much @PikachuEXE installing '2.2.3.alpha4' resolved this issue for me. |
|
Fix released in https://rubygems.org/gems/gem-release/versions/2.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
plugins/gem-release_plugin.rb": cannot load such file -- gem/release (LoadError)rubygems/rubygems#5289To test:
gem uninstall gem-releasegem install gem-release -v '2.2.3.alpha4'Update 1: Instead of rescuing
LoadError, userequire_relativeas suggested in #111 (review)