fix: add browser to default resolve.mainFields #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
approved these changes
Nov 21, 2023
|
FYI when using this library https://github.com/Cweili/svelte-fa/blob/master/package.json the update to v3.0.1 make the library failed now (v3.0.1) while with v3.0.0 it was working (with vite5) |
Hi, please file an issue report with a minimal reproduction. the package.json of that library looks very complex and it's possible that this change unmasked a preexisting issue that was never triggered before due to the previous svelte field resolution algorithm |
benmccann
pushed a commit
to benmccann/vite-plugin-svelte
that referenced
this pull request
Nov 28, 2023
* fix: add browser to default resolve.mainFields * chore: fix test --------- Co-authored-by: bluwy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #808