-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowers log level to debug #806
Lowers log level to debug #806
Conversation
This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this.
@dominikg as requested; here goes. I was pretty confident you don't require tests for logging, so this PR is as bare-bones as it gets. |
the PR also needs a changeset, you can create it with |
This commit adds a debug section for "hmr" to the line, as suggested by @dominikg. Co-authored-by: Dominik G. <[email protected]>
Changeset created, waiting for approval. |
Hi @Radiergummi and @dominikg, I was trying to solve the issue, found the bug and after solving it, I came to see that @Radiergummi has already raised a PR. So, I am uploading my changes anyway, thanks. |
Thank you @Radiergummi ! @Augasty raising a duplicate PR is usually not a good idea, but participating in issues and PRs is. Your PR itself looks fine too, but this one is going ahead as it was first. |
Absolutely okay with it. And thanks a lot for feedback. |
This message isn't immediately actionable for developers and can reasonably be considered debugging output. Therefore, the log level has been updated to reflect this.
This fixes #803.