Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle closing tags in attributes #796

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix: handle closing tags in attributes #796

merged 2 commits into from
Nov 22, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 16, 2023

...when detecting script language
Related to sveltejs/language-tools#2204
Let me know if there's any other place where this needs a fix

...when detecting script language
Related to sveltejs/language-tools#2204
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If we backport this to main, we also need to update these two places (for error reporting only):

const scriptRe = /<script(\s[^]*?)?(?:>([^]*?)<\/script>|\/>)/gi;

const styleRe = /<style(\s[^]*?)?(?:>([^]*?)<\/style>|\/>)/gi;

@dummdidumm
Copy link
Member Author

Thanks! I'll do a corresponding PR for main 👍

@dominikg
Copy link
Member

can we do it on main first and cherry pick the change to v2? now that main is no longer in pre-release that flow makes the most sense to me. although with the amount of changes between main and v2 it can become difficult to pick sometimes.

@dominikg dominikg merged commit 4b8918d into v2 Nov 22, 2023
7 checks passed
@dominikg dominikg deleted the script-language-v2 branch November 22, 2023 12:44
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants