fix: lazily connect derievds (in deriveds) to their parent #15129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1867f40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Tried version from this PR on our codebase. The issue is fixed. Also I clicked through the app and there are no observable regressions otherwise from the first glance. Thank you for digging into it and your swift fix! |
Rich-Harris
approved these changes
Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15111.
We don't need to eagerly connect deriveds to their parents – we don't do this in effects, so we can apply the same heuristic here too. If we lazily do it upon read of the derived from within a parent derived. If no read is done, we skip pushing it into the children. This will avoid the buggy case linked, and also provide a nice performance uplift by avoiding array allocations for cases where don't need to do them.