Skip to content

Commit

Permalink
chore: remove unused code from signal logic (#15195)
Browse files Browse the repository at this point in the history
  • Loading branch information
trueadm authored Feb 3, 2025
1 parent e12fe87 commit e0b3dc0
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 28 deletions.
5 changes: 5 additions & 0 deletions .changeset/blue-sheep-joke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: remove unused code from signal logic
12 changes: 0 additions & 12 deletions packages/svelte/src/internal/client/reactivity/deriveds.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,3 @@ export function update_derived(derived) {
derived.wv = increment_write_version();
}
}

/**
* @param {Derived} derived
* @returns {void}
*/
export function destroy_derived(derived) {
destroy_derived_effects(derived);
remove_reactions(derived, 0);
set_signal_status(derived, DESTROYED);

derived.v = derived.deps = derived.ctx = derived.reactions = null;
}
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/reactivity/effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import * as e from '../errors.js';
import { DEV } from 'esm-env';
import { define_property } from '../../shared/utils.js';
import { get_next_sibling } from '../dom/operations.js';
import { derived, destroy_derived } from './deriveds.js';
import { derived } from './deriveds.js';
import { component_context, dev_current_component_function } from '../context.js';

/**
Expand Down
16 changes: 1 addition & 15 deletions packages/svelte/src/internal/client/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,7 @@ import {
} from './constants.js';
import { flush_tasks } from './dom/task.js';
import { internal_set } from './reactivity/sources.js';
import {
destroy_derived,
destroy_derived_effects,
execute_derived,
update_derived
} from './reactivity/deriveds.js';
import { destroy_derived_effects, update_derived } from './reactivity/deriveds.js';
import * as e from './errors.js';
import { FILENAME } from '../../constants.js';
import { tracing_mode_flag } from '../flags/index.js';
Expand Down Expand Up @@ -919,15 +914,6 @@ export function get(signal) {
var flags = signal.f;
var is_derived = (flags & DERIVED) !== 0;

// If the derived is destroyed, just execute it again without retaining
// its memoisation properties as the derived is stale
if (is_derived && (flags & DESTROYED) !== 0) {
var value = execute_derived(/** @type {Derived} */ (signal));
// Ensure the derived remains destroyed
destroy_derived(/** @type {Derived} */ (signal));
return value;
}

if (captured_signals !== null) {
captured_signals.add(signal);
}
Expand Down

0 comments on commit e0b3dc0

Please sign in to comment.