Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form action submit function callback return type #13420

Conversation

McAllaster
Copy link
Contributor

@McAllaster McAllaster commented Feb 4, 2025

Allow for form action submit function callbacks to be asynchronous functions.

Closes #13419


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • Not sure if I need to do this for a type change?

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 4b8c747

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@McAllaster
Copy link
Contributor Author

Apparently I was unfamiliar with the generated types, and pnpm check having a file output (for generating types) rather than just failing if there was something wrong. I'm going to convert this to a draft for now.

@McAllaster McAllaster marked this pull request as draft February 4, 2025 22:00
@McAllaster McAllaster force-pushed the form-action-callback-return-type branch from ccbacde to 0eec7a0 Compare February 4, 2025 22:28
@McAllaster McAllaster force-pushed the form-action-callback-return-type branch from 0eec7a0 to 5891b99 Compare February 4, 2025 22:32
@McAllaster McAllaster marked this pull request as ready for review February 4, 2025 22:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit 9612a60 into sveltejs:main Feb 6, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
@McAllaster McAllaster deleted the form-action-callback-return-type branch February 6, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Actions: SubmitFunction callback return type
3 participants