Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Assign ports per-app for integration tests #13338

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Assign ports per-app for integration tests #13338

wants to merge 4 commits into from

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

I was just experimenting with some test stuff, no need to worry

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0f8972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13338-svelte.vercel.app/

this is an automated message

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github marked this pull request as ready for review January 17, 2025 21:56
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github force-pushed the 01-17-feat_assign_ports_per-app_for_integration_tests branch from d6b4cb0 to a0f8972 Compare January 18, 2025 03:39
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github commented Jan 22, 2025
View reviewed changes
packages/kit/test/util-types.d.ts
Comment on lines +11 to 21
export type CustomTestType = TestType<
PlaywrightTestArgs &
PlaywrightTestOptions & {
app: {
goto(url: string, opts?: { replaceState?: boolean }): Promise<void>;
invalidate(url: string): Promise<void>;
beforeNavigate(url: URL): void | boolean;
afterNavigate(url: URL): void;
beforeNavigate(callback: () => void): void;
afterNavigate(callback: () => void): void;
preloadCode(pathname: string): Promise<void>;
preloadData(url: string): Promise<void>;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure there are types here that are just straight up not correct

elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github commented Jan 22, 2025
View reviewed changes
packages/kit/test/utils.js
webServer: {
command: process.env.DEV ? 'pnpm dev --force' : 'pnpm build && pnpm preview',
port: process.env.DEV ? 5173 : 4173
export const app_ports = /** @type {const} */ {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to figure out how to assign these fully-dynamically at runtime, but didn't have any ideas that sounded very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliott-with-the-longest-name-on-github @Rich-Harris