-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect replace_state on external navigation where applicable #13303
base: main
Are you sure you want to change the base?
respect replace_state on external navigation where applicable #13303
Conversation
🦋 Changeset detectedLatest commit: fcaa948 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13303-svelte.vercel.app/ this is an automated message |
|
@eltigerchino thank you, I had read the docs goto is not meant to be used to navigate outside the app, but still it is used for same domain navigation, so why not do it correctly? |
I think even if it's the same domain but not a part of the app it's still considered "outside the app", so you should use |
@eltigerchino in theory I agree, but in practice it is quite convenient to use svelte-kit's mechanism to define which route is inside or outside of my current app. With file based routing you need some kind of manifest to determine if you navigate outside and as far as I know we don't have anything like that for client-side |
When navigating via goto with
replaceState: true
with full page reload (e.g. navigating outside of the app) the page is not being replaced, but pushed to history insteadThis PR aims to fix that
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits