Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect replace_state on external navigation where applicable #13303

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

konstantinov90
Copy link

@konstantinov90 konstantinov90 commented Jan 13, 2025

When navigating via goto with replaceState: true with full page reload (e.g. navigating outside of the app) the page is not being replaced, but pushed to history instead
This PR aims to fix that


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: fcaa948

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13303-svelte.vercel.app/

this is an automated message

@eltigerchino
Copy link
Member

goto is not meant to be used to navigate outside the app. From the docs:

For external URLs, use window.location = url instead of calling goto(url).

https://svelte.dev/docs/kit/$app-navigation#goto

@konstantinov90
Copy link
Author

@eltigerchino thank you, I had read the docs

goto is not meant to be used to navigate outside the app, but still it is used for same domain navigation, so why not do it correctly?

@eltigerchino
Copy link
Member

eltigerchino commented Jan 15, 2025

I think even if it's the same domain but not a part of the app it's still considered "outside the app", so you should use window.location = url instead.

@eltigerchino eltigerchino reopened this Jan 15, 2025
@konstantinov90
Copy link
Author

konstantinov90 commented Jan 15, 2025

@eltigerchino in theory I agree, but in practice it is quite convenient to use svelte-kit's mechanism to define which route is inside or outside of my current app. With file based routing you need some kind of manifest to determine if you navigate outside and as far as I know we don't have anything like that for client-side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants