Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkjs library template #428

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

paoloricciuti
Copy link
Member

I don't know if this is the right fix...it took me a bit of fiddling to understand how it worked. I renamed the ``+library-typescriptfolder to+library-typescript-checkjs` so that it doesn't override the `+checkjs` one but still adds it for `none`.

I've also added the none language to the tests.

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 5931c98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@428
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@428

commit: 5931c98

@manuel3108 manuel3108 linked an issue Jan 31, 2025 that may be closed by this pull request
@manuel3108
Copy link
Member

Thanks!

Fixed changeset, see #403

@manuel3108 manuel3108 merged commit c501bcc into main Jan 31, 2025
7 checks passed
@manuel3108 manuel3108 deleted the fix--checkjs-library-template branch January 31, 2025 15:54
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv create library with jsdoc missing checkJs
2 participants