-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add update-condition for github-comment exec #1722
base: main
Are you sure you want to change the base?
feat: add update-condition for github-comment exec #1722
Conversation
🤔
|
@@ -345,3 +355,75 @@ func (c *ExecController) handleOutput(ctx context.Context, cmt *github.Comment, | |||
} | |||
return nil | |||
} | |||
|
|||
func (c *ExecController) setUpdatedCommentID(ctx context.Context, cmt *github.Comment, updateCondition string) error { //nolint:funlen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is almost identical to post command, so I think refactoring it other PR.
@suzuki-shunsuke What do you think? We are using |
Sorry, I'll take a look this weekend. |
Check List
Require signed commits
, so all commits must be signedI have added
--update-conditon
to exec sub-command so that existing comments can be overwritten. post implementation as a reference (PR: #473)related: