Button component #711
Button component #711
Conversation
dzonidoo
requested review from
MarkLark86,
petrjasek and
thecalcc
and removed request for
petrjasek,
MarkLark86 and
thecalcc
dzonidoo
changed the title
* add navigation * changes after review * fix lint * chages after review
|
hi @dzonidoo can you update the PR so we can merge it? |
* add navigation * changes after review * fix lint * chages after review
There was a problem hiding this comment.
would rename this so it matches the component name like all the other files
| export type IPropsSize = 'small' | 'medium' | 'large'; | ||
|
|
||
| export interface IPropsButtonBase { | ||
| value: string; |
There was a problem hiding this comment.
imo would be better to work with children so it's more like regular button, or call this label because there is no value really like on an input
| } | ||
|
|
||
| interface IPropsReset extends IPropsButtonBase { | ||
| type?: 'reset', |
There was a problem hiding this comment.
I guess here the type must be reset so should be probably just type: 'reset',
I'm also wondering if we have a usecase where we wouldn't use it with onClick, might be better to make it mandatory if not to get this checked.
same applies to submit
| import PropTypes from 'prop-types'; | ||
| import {gettext} from 'utils'; | ||
|
|
||
| function CloseModalButton({onClick}: any) { |
There was a problem hiding this comment.
I wonder what's the usecase for having this one and CloseButton which seems to handle modals as well
NHUB-464
Checklist
lodash.getwith optional chaining for modified code segments