Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows requires key in control file to specify only certain allow-listed extensions #143

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

imor
Copy link
Contributor

@imor imor commented Nov 10, 2023

What kind of change does this PR introduce?

Feature

What is the current behavior?

  • Values of the requires and relocatable keys were not sent to the backend when publishing a package.
  • Anything was allowed in the requires key in the control file.
  • Message Nothing to publish was shown by the CLI even though package's properties were updated.

What is the new behavior?

  • requires and relocatable will be sent to the backend when publishing a package. These are optional for now for backward compatibility with older CLI versions. We will remove the publish_package(package_name app.valid_name, package_description varchar(1000) function once the newer CLI version is widely abopted.
  • Only extension names in the app.allowed_extensions table are allowed in the requires key in the control file. Currently extensions available on Supbase and AWS RDS are allow-listed.
  • Message Updated package properties will now be shown to indicate that relocatable and requires keys have been updated.

Additional context

Fixes #131

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dbdev ✅ Ready (Inspect) Visit Preview Nov 10, 2023 9:11am

@imor imor merged commit ff884dc into master Nov 11, 2023
@imor imor deleted the requires_fixes branch November 11, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent TLEs from referencing other TLEs in requires
2 participants