Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve saml assertion logging #1915

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: improve saml assertion logging #1915

merged 1 commit into from
Jan 22, 2025

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Logs the Response returned from the library as well

@kangmingtay kangmingtay requested a review from a team as a code owner January 15, 2025 18:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12795084859

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.435%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/samlacs.go 0 1 0.0%
Totals Coverage Status
Change from base Build 12786188298: 0.0%
Covered Lines: 9814
Relevant Lines: 14998
💛 - Coveralls

@hf hf merged commit d6030cc into master Jan 22, 2025
5 checks passed
@hf hf deleted the km/improve-saml-logging branch January 22, 2025 08:59
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @hf