Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge release/2.165.0 into master #1875

Merged
merged 2 commits into from
Dec 16, 2024
Merged

chore: merge release/2.165.0 into master #1875

merged 2 commits into from
Dec 16, 2024

Conversation

cstockton
Copy link
Contributor

This merges a small release hotfix committed into the releases branch back into master.

kangmingtay and others added 2 commits December 6, 2024 17:31
## What kind of change does this PR introduce?
* Request made to email validation service should be a `POST`
* Update error message when config validation fails
🤖 I have created a release *beep* *boop*
---


##
[2.165.1](v2.165.0...v2.165.1)
(2024-12-06)


### Bug Fixes

* allow setting the mailer service headers as strings
([#1861](#1861))
([7907b56](7907b56))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cstockton cstockton requested a review from a team as a code owner December 16, 2024 19:38
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after you remove CHANGELOG from the PR.

@hf
Copy link
Contributor

hf commented Dec 16, 2024

Actually I think the CHANGELOG will be fine. Go ahead!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12360011718

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 57.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/conf/configuration.go 0 1 0.0%
internal/mailer/validate.go 2 3 66.67%
Totals Coverage Status
Change from base Build 12312977263: -0.003%
Covered Lines: 9709
Relevant Lines: 16956

💛 - Coveralls

@cstockton cstockton merged commit a3eecd1 into master Dec 16, 2024
4 checks passed
@cstockton cstockton deleted the release/2.165.0 branch December 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants