add a dedicated redirect url parameter for a password reset flow #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dshukertjr can you review this PR ? it seems like I don't have a right to assign reviewers in this repository. |
|
Thanks for the PR! 😊 |
|
closing as I've found an workaround to handle a password reset flow. |
you wanna maybe share what you did @HQHAN this would be very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR addresses an issue where the redirectTo in SupaEmailAuth, intended for confirming a signup email, was also used for the password reset confirmation flow. This overlap makes it difficult to implement a follow-up UX flow, such as transitioning to the password reset screen after verifying the redirect URL for a password reset.
What is the current behavior?
Currently, after clicking on the confirmation URL in a password reset confirmation email, the application receives the same redirect URL set for the signup confirmation flow.
What is the new behavior?
With this change, the application will receive a dedicated redirect URL for password reset, distinct from the signup confirmation URL.
Additional context
While the app can subscribe to the AuthChangeEvent.passwordRecovery event to handle the password reset flow, redirecting with the exact deep link URL provides a more straightforward approach.