Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextInputAction to phone and email sign in #82

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

pohuing
Copy link
Contributor

@pohuing pohuing commented Mar 31, 2024

What kind of change does this PR introduce?

This PR introduces TextInputActions to the email and phone sign-up/-in forms.

What is the current behavior?

#81

What is the new behavior?

A small QoL change in the way that phone keyboards are configured for traversing the forms. The change is the "next" right arrows button in the bottom right of the keyboard.

with.actions.webm

Additional context

Add any other context or screenshots.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you so much for this. It seems like there is a merge conflict with your other PR that I just merged, but would you be able to take care of it?

# Conflicts:
#	lib/src/components/supa_email_auth.dart
#	lib/src/components/supa_phone_auth.dart
@pohuing
Copy link
Contributor Author

pohuing commented Apr 1, 2024

Conflicts are fixed now

@pohuing
Copy link
Contributor Author

pohuing commented Apr 11, 2024

Hey, are there any holdups still left?

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Thanks for this amazing update!

@dshukertjr dshukertjr merged commit b3454fa into supabase-community:main Apr 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants