-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post on using coordinates to model loops #133
Conversation
Oh man that renders lovely: https://deploy-preview-133--sunpy.netlify.com/posts/2018/2018-07-21-coronal-loop-coordinates.html |
The only comment with this is that some of the code in the cells is too wide for the width of the code cells. We should probably try and make the code cells wider? |
Also is there a "download this notebook" link we can build in somewhere? |
Yeah I agree that the code cells are annoyingly narrow. I tried to avoid long lines when writing the notebook so that it is more readable. Glancing at nbsphinx and even nbconvert, it doesn't seem there's an easy way to adjust the code cell width. |
I would take a guess that it's being limited by our theme css. @nabobalis ? |
Re: a download link, I have a PR ready for #132 that will automatically generate a link to the static notebook and the binder notebook at the top of each post. Because I'm bad at branching, it is easier to merge this PR first and then I'll submit the other. |
Oh true. That box on the left is pretty wide. Maybe making that a bit more narrow would help. |
Maybe? We can change the CSS tho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We could also CSS out the input and output cell markers? That gives us quite a bit more space? |
Probably? I don't think we touch those normally in the CSS. |
Is the problem the code cells have scroll bars? |
Could do. That may involve a PR to nbsphinx |
Also @wtbarnes I would put your bio at the top. |
We could just do it in the sunpy theme I would think. |
Feels like it might be too distracting at the top |
To strip out the |
Could we not somehow use these? https://github.com/jupyter/nbconvert-examples/tree/master/latex_cell_style |
I think sunpy/sunpy-sphinx-theme#58 should do the job |
Sure, but I think the issue is getting nbsphinx to use your custom template (i.e. |
@Cadair nice |
How much control does nbsphinx give you over the colour scheme of the cells? I don't like the lack of contrast in the current ones, not great for accessibility etc. |
I think it just depends on the syntax highlighter you're using. |
You can set the pygments style in the |
Nabil you wanna roll out a theme update before or after merging this? |
Err, either? |
I leave it up to you. |
Done. You can revert it back to normal now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once more
🎉 |
This blog post is a tutorial for using the
sunpy.coordinates
module for modeling loops on the Sun. Any feedback (on the code and/or text) is greatly appreciated!