fix: resource does not properly close context managers

suned · Feb 3, 2021 · c3809fb · c3809fb
1 parent 1623ff7
commit c3809fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pfun/effect.py b/pfun/effect.py
@@ -172,7 +172,7 @@ async def __aenter__(self):
     async def __aexit__(self, *args, **kwargs):
         resource = self.resource
         object.__setattr__(self, 'resource', None)
-        if isinstance(self.resource, Right):
+        if isinstance(resource, Right):
             return await resource.get.__aexit__(*args, **kwargs)
 
 

diff --git a/tests/test_effect.py b/tests/test_effect.py
@@ -265,6 +265,7 @@ def test_get(self):
         effect = resource.get()
         assert effect.run(None) == mock_resource
         mock_resource.__aenter__.assert_called_once()
+        mock_resource.__aexit__.assert_called_once()
         assert resource.resource is None
 
     def test_resources_are_unique(self):