Vary commonmarker pin depending on Ruby version #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 is unsupported until commonmarker 2.0.2, but 2.0.2 breaks Ruby 3.3. See gjtorikian/commonmarker#333. This change allows cocina-models dependents to use either Ruby 3.3 or 3.4.
mjgiarlo
force-pushed
the
unpin-commonmarker
branch
from
fd3802d to
f58a929
Compare
mjgiarlo
changed the title
justinlittman
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Ruby 3.4 is unsupported in commonmarker until v2.0.2, but v2.0.2 breaks Ruby 3.3. See gjtorikian/commonmarker#333 for the underlying issue. This change allows
cocina-modelsdependents to use either Ruby 3.3 or 3.4. Ultimately we hope that an eventual v2.0.3 release will work on both rubies, and we can remove this logic. I'm tracking the issues/pulls related to this bug, and will follow up when I see that it has been resolved.How was this change tested?
CI