[HOLD] Fix validation of description values including title #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwrubel
commented
Feb 5, 2024
| @@ -62,22 +62,30 @@ def validate_values_for_blanks(hash, path) | |||
| end | |||
|
|
|||
| def validate_values_for_multiples(hash, path) | |||
| return unless hash.count { |key, value| %i[value groupedValue structuredValue parallelValue].include?(key) && value.present? } > 1 | |||
| return unless hash.count { |key, value| %w[value groupedValue structuredValue parallelValue].include?(key) && value.present? } > 1 | |||
There was a problem hiding this comment.
keys are strings, rather than symbols.
There was a problem hiding this comment.
How do we know these keys are strings?
The entrypoint to the DescriptionValuesValidator class is the Validator class, which converts the attributes to be validated into a HashWithIndifferentAccess instance.
The HashWithIndifferentAccess class maps symbol keys to string keys in its writing interface. Thus:
[y]ou are guaranteed that the key is returned as a string
(see https://api.rubyonrails.org/classes/ActiveSupport/HashWithIndifferentAccess.html)
There was a problem hiding this comment.
Thank you for explaining/documenting this in detail!
lwrubel
changed the title
lwrubel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
HOLD because data in prod needs remediation.
Follow-on to #675 (see sul-dlss/argo#4279 and also #424) to make sure that ValidationError is raised in several invalid title and other DescriptiveValue situations.
How was this change tested?
Unit. When running a dor-services-app instance locally in docker with the cocina-models branch, error is raised by DSA when an invalid update sent from Argo spreadsheet upload.
Ran
bin/validate-cocina. There are 244 invalid druids in prod, none in qa or stage. Gave @arcadiafalcone the list of problem druids for remediation in sul-dlss/argo#4279. They are all for"Multiple value, groupedValue, structuredValue, and parallelValue in description"errors.