fix: deferred checkpoints optimization #1973
Open
+42
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ctian1
commented
Jan 23, 2025
•
ctian1
commented
- Currently, the entire ExecutionState.proof_stream is being cloned for every checkpoint, which is very wasteful for programs with many deferred proofs. Since it's only used as a runtime check, we can skip the clone and verification with checkpoints.
ctian1
changed the title
| @@ -33,7 +33,7 @@ jobs: | |||
| pull_token: ${{ secrets.PULL_TOKEN }} | |||
|
|
|||
| # If it's a nightly release, tag with the release time. If the tag is `main`, we want to use | |||
| # `latest` as the tag name. Else, use the tag name as is. | |||
| # `latest` as the tag name. else, use the tag name as is. | |||
There was a problem hiding this comment.
Are these changes relevant?
There was a problem hiding this comment.
Are these changes relevant?
ratankaliani
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.