Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway - use endpoint set private, public and healthcheck IPs #3279

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Gateway - use endpoint set private, public and healthcheck IPs #3279

merged 2 commits into from
Jan 22, 2025

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Jan 19, 2025

This PR :

  • updates gateway code to use endpoint SetHealthCheckIP ,SetPrivateIP and SetPublicIP.
  • add placeholders for IPV6 public,private and healthcheck IPs.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3279/yboaron/add_cluster_ipfamily
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@yboaron yboaron force-pushed the add_cluster_ipfamily branch 2 times, most recently from ff5edbd to c417ac3 Compare January 20, 2025 12:04
@yboaron yboaron added the ready-to-test When a PR is ready for full E2E testing label Jan 20, 2025
tpantelis
tpantelis requested changes Jan 20, 2025
View reviewed changes
pkg/endpoint/local_endpoint.go Show resolved Hide resolved
pkg/endpoint/local_ip.go Outdated Show resolved Hide resolved
pkg/endpoint/public_ip.go Outdated Show resolved Hide resolved
pkg/types/types.go Outdated Show resolved Hide resolved
@yboaron yboaron force-pushed the add_cluster_ipfamily branch 2 times, most recently from ca96dd7 to 5f7606c Compare January 20, 2025 16:08
tpantelis
tpantelis requested changes Jan 20, 2025
View reviewed changes
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
@yboaron yboaron force-pushed the add_cluster_ipfamily branch from 5f7606c to b1326ef Compare January 21, 2025 11:15
tpantelis
tpantelis requested changes Jan 21, 2025
View reviewed changes
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
pkg/endpoint/local_endpoint.go Outdated Show resolved Hide resolved
pkg/endpoint/public_ip_watcher.go Outdated Show resolved Hide resolved
pkg/endpoint/public_ip_watcher.go Outdated Show resolved Hide resolved
@yboaron
Gateway - use endpoint set private, public and healthcheck IPs
4434394 
This PR :
- updates gateway code to use endpoint SetHealthCheckIP
,SetPrivateIP and SetPublicIP.
- add placeholders for IPV6 public,private and healthcheck IPs.

Signed-off-by: Yossi Boaron <[email protected]>
@yboaron yboaron force-pushed the add_cluster_ipfamily branch from b1326ef to 4434394 Compare January 22, 2025 11:21
@tpantelis tpantelis enabled auto-merge (rebase) January 22, 2025 18:04
@tpantelis tpantelis merged commit 22d93de into submariner-io:devel Jan 22, 2025
39 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3279/yboaron/add_cluster_ipfamily]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Submariner 0.20
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yboaron @submariner-bot @dfarrell07 @tpantelis