Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a few new linters #3269

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Enable a few new linters #3269

merged 2 commits into from
Jan 20, 2025

Conversation

skitt
Copy link
Member

@skitt skitt commented Jan 16, 2025

  • exptostd ensures features in the standard library are used rather than their experimental predecessors
  • nilnesserr flags error checks that don’t return the checked error
  • usetesting flags function calls that should be replaced with variants in the testing package

@skitt
Enable a few new linters
55c303d 
* exptostd ensures features in the standard library are used rather
  than their experimental predecessors
* nilnesserr flags error checks that don’t return the checked error
* usetesting flags function calls that should be replaced with
  variants in the testing package

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3269/skitt/golangci-lint-new-linters
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jan 20, 2025
@tpantelis tpantelis enabled auto-merge (rebase) January 20, 2025 18:01
@tpantelis tpantelis merged commit 662dbfd into submariner-io:devel Jan 20, 2025
40 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3269/skitt/golangci-lint-new-linters]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

@yboaron yboaron Awaiting requested review from yboaron yboaron is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @dfarrell07 @tpantelis