-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry mechanism to CNI interface discovery on kube-proxy handler #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that even though RA pod starts running only after the node is ready, sometimes the kube-proxy handler fails to discover the CNI interface a fter the node is rebooted. This PR adds a retry to CNI discovery. Fixes: submariner-io#3120 Signed-off-by: Yossi Boaron <[email protected]>
yboaron
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
August 14, 2024 13:19
🤖 Created branch: z_pr3121/yboaron/cni_if_retry_discovery |
tpantelis
approved these changes
Aug 15, 2024
skitt
approved these changes
Aug 19, 2024
🤖 Closed branches: [z_pr3121/yboaron/cni_if_retry_discovery] |
dfarrell07
added
backport
This change requires a backport to eligible release branches
release-note-needed
Should be mentioned in the release notes
labels
Aug 20, 2024
yboaron
added a commit
to yboaron/submariner
that referenced
this pull request
Aug 22, 2024
…3121-origin-release-0.17
yboaron
added a commit
to yboaron/submariner-website
that referenced
this pull request
Sep 24, 2024
submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]>
yboaron
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 30, 2024
* Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 25, 2024
…o#1177) * Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
dfarrell07
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 25, 2024
* Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
This change requires a backport to eligible release branches
backport-handled
ready-to-test
When a PR is ready for full E2E testing
release-note-handled
release-note-needed
Should be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that even though RA pod starts running only after the node is ready, sometimes the kube-proxy handler fails to discover the CNI interface after the node is rebooted.
This PR adds a retry to CNI discovery.
Fixes: #3120