Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump lighthouse to fix e2e #1242

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Bump lighthouse to fix e2e #1242

merged 1 commit into from
Oct 2, 2024

Conversation

vthapar
Copy link
Contributor

@vthapar vthapar commented Oct 2, 2024 •
edited by tpantelis
Loading

No description provided.

@vthapar
Test lighthouse e2e fix
f34ba4d 
Do Not Merge this

Signed-off-by: Vishal Thapar <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1242/vthapar/test-lh-e2e-fix
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt marked this pull request as draft October 2, 2024 08:39
@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Oct 2, 2024
@tpantelis tpantelis marked this pull request as ready for review October 2, 2024 13:20
@tpantelis tpantelis changed the title Test lighthouse e2e fix Bump lighthouse to fix e2e Oct 2, 2024
@tpantelis tpantelis merged commit 72fa0d2 into submariner-io:release-0.19 Oct 2, 2024
39 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1242/vthapar/test-lh-e2e-fix]

@skitt
Copy link
Member

skitt commented Oct 2, 2024

Heh, now we have a commit saying “Do Not Merge this” in the history ;-).

@tpantelis
Copy link
Contributor

Heh, now we have a commit saying “Do Not Merge this” in the history ;-).

Crap. Sorry I forgot to update the commit too in my haste.

@skitt
Copy link
Member

skitt commented Oct 2, 2024

Crap. Sorry I forgot to update the commit too in my haste.

Wasn’t the commit redundant anyway? The dependency will be bumped by the release process.

@tpantelis
Copy link
Contributor

Crap. Sorry I forgot to update the commit too in my haste.

Wasn’t the commit redundant anyway? The dependency will be bumped by the release process.

Yes but the release process runs E2E which uses subctl which happens before the bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan is a code owner

@dfarrell07 dfarrell07 Awaiting requested review from dfarrell07 dfarrell07 is a code owner

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vthapar @submariner-bot @skitt @tpantelis