Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom VPC support in GCP #1060

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

aswinsuryan
Copy link
Contributor

Add custom VPC support in GCP

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1060/aswinsuryan/gcp-custom-vpc

@aswinsuryan aswinsuryan force-pushed the gcp-custom-vpc branch 12 times, most recently from 130eca6 to 46070f3 Compare December 12, 2024 00:57
@aswinsuryan aswinsuryan marked this pull request as ready for review December 12, 2024 01:14
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

pkg/gcp/gcp.go Outdated Show resolved Hide resolved
@aswinsuryan aswinsuryan force-pushed the gcp-custom-vpc branch 2 times, most recently from c954a10 to 49dccb3 Compare January 7, 2025 23:07
pkg/gcp/ocpgwdeployer.go Outdated Show resolved Hide resolved
pkg/gcp/ocpgwdeployer.go Outdated Show resolved Hide resolved
@aswinsuryan aswinsuryan force-pushed the gcp-custom-vpc branch 3 times, most recently from 47d06fe to 971a03f Compare January 8, 2025 03:16
@aswinsuryan aswinsuryan force-pushed the gcp-custom-vpc branch 5 times, most recently from 58a0958 to e5e617e Compare January 8, 2025 04:08
pkg/gcp/ocpgwdeployer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tpantelis tpantelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to approve yet.

Signed-off-by: Aswin Suryanarayanan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants