Fix aws cloud prepare failure #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1026/aswinsuryan/aws-cloud-prepare |
aswinsuryan
force-pushed
the
aws-cloud-prepare
branch
9 times, most recently
from
b80e6c9 to
d30d097
Compare
aswinsuryan
force-pushed
the
aws-cloud-prepare
branch
from
d30d097 to
88c4202
Compare
Signed-off-by: Aswin Suryanarayanan <[email protected]>
aswinsuryan
force-pushed
the
aws-cloud-prepare
branch
from
88c4202 to
af4d397
Compare
aswinsuryan
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
tpantelis
approved these changes
Oct 5, 2024
Can you be a bit more specific about the failure? |
yboaron
approved these changes
Oct 7, 2024
|
🤖 Closed branches: [z_pr1026/aswinsuryan/aws-cloud-prepare] |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix aws cloud prepare failure .
When the public subnets are parsed to identify the prefix the variable is redeclared inside the else block and this causes the variable outside scope of the else to be empty after the block exists. Now the variable declaration is removed.