Address intrange linter violations

"for loop can be changed to use an integer range"

Signed-off-by: Tom Pantelis <[email protected]>

pkg/ocp/machinesets.go

@@ -219,11 +219,11 @@ func (msd *k8sMachineSetDeployer) List() ([]unstructured.Unstructured, error) {
 func RemoveDuplicates(machineSets []unstructured.Unstructured, gwNodes []v1.Node) []v1.Node {
 	var resultNode []v1.Node
 
-	for i := 0; i < len(gwNodes); i++ {
+	for i := range gwNodes {
 		addToResult := true
 
-		for i := 0; i < len(machineSets); i++ {
-			if strings.Contains(gwNodes[i].GetName(), machineSets[i].GetName()) {
+		for j := range machineSets {
+			if strings.Contains(gwNodes[i].GetName(), machineSets[j].GetName()) {
 				addToResult = false
 				break
 			}

pkg/rhos/ocpgwdeployer.go

@@ -214,7 +214,7 @@ func (d *ocpGatewayDeployer) deployGWNode(gatewayCount int,
 func (d *ocpGatewayDeployer) deployDedicatedGWNode(gatewayNodesToDeploy int, useInternalSG bool,
 	status reporter.Interface,
 ) error {
-	for i := 0; i < gatewayNodesToDeploy; i++ {
+	for i := range gatewayNodesToDeploy {
 		gwNodeName := d.InfraID + "-submariner-gw" + strconv.Itoa(i)
 		status.Start("Deploying dedicated Submariner gateway node %s", gwNodeName)