feat/106: start adding log level adjustments #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devanbenz
commented
Jun 24, 2024
devanbenz
commented
- Starts adding logging level checking via ENV for DEBUG logs
|
@lazyguru What levels should we be indicating? In most other services that I've worked on we LOG warns/errors/info and then require a flag for DEBUG. Should we be doing that here? If so this PR is basically that lol. Pretty simple. |
lazyguru
requested changes
Jun 28, 2024
There was a problem hiding this comment.
That's not how you should configure logging. We are using ZeroLog which already has a facility for configuring log level: https://github.com/rs/zerolog?tab=readme-ov-file#setting-global-log-level
|
Closing in favor of #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.