[JavaScript] Fix const arrow functions in TSX #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit...
1. adds named contexts for parenthesized expressions
2. adds dedicated context for parenthesized expressions in typescript,
to fail early when detecting type annotation without leaking
`fail: arrow-function` to unrelated contexts.
This may have had unexpected consequences.
3. re-arranges old-style type assertion syntax to group related contexts
It was odd to see arrow function and expression related contexts
between export/import statement related contexts.
4. optimizes expression/arrow function detection related contexts by removing
redundant lookaheads and reduce required context switches.
Note: This commit does not change parsing behavior. It is just a reliability,
maintainability and small performance fix.
This commit ... 1. drops `jsx-attribute-value` and implements value string patterns directly into `jsx-tag-attributes` context to simplify overall structure. This also drops a `jsx-tag` include, which doesn't seem to make any sense, as nested tags within jsx tags are not supported. It may even be reason for various lockups which JSX/TSX suffered from in the past. 2. adds named contexts for jsx tag value strings. 3. scopes jsx tag value strings `meta.string`. As a result syntax of JSX tag attributes is a bit more permissive with regards to missing `=` operators.
This commit... 1. converts anonymous JSX child tag contexts to named contexts 2. adds tests to verify deep nesting works
This commit just moves some JSX/TSX related contexts to group and bring them into a more logical order.
This commit reduces amount of contexts pushed on stack to handle unmatched tags. As new merged context shares patterns with `jsx-expect-tag-end` compiled syntax cache doesn't change.
deathaxe
force-pushed
the
pr/javascript/fix-tsx-generic-arrow-functions
branch
from
43e4f30 to
28dbfd9
Compare
keith-hall
approved these changes
Dec 18, 2024
jfcherng
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4112
This PR refactors JSX/TSX tag related contexts and arrow function detection to improve reliability, maintainability and fix some possible causes of former lockups as well as a conflict with generic arrow functions using constant type parameters.
It's a bit of fixing and cleaning.
Parsing performance is more or less unaffected.